Discussion:
spiped 1.2.2 released
Colin Percival
2012-11-15 08:02:26 UTC
Permalink
Hi all,

I've just released spiped 1.2.2; this is the same as the spiped 1.2.2f
which I pointed people at last week with the exception of some updates
to documentation. Available from the usual location:
https://www.tarsnap.com/spiped.html
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
James Turner
2012-11-15 17:58:24 UTC
Permalink
Post by Colin Percival
Hi all,
I've just released spiped 1.2.2; this is the same as the spiped 1.2.2f
which I pointed people at last week with the exception of some updates
https://www.tarsnap.com/spiped.html
Excellent!

When I submitted the updated port to the OpenBSD mailing list I had the
following build warning pointed out that I didn't previously notice:

../lib/events/events_network.c:222: warning: incompatible implicit
declaration of built-in function 'memset'

On OpenBSD, the FD_ZERO macro uses memset so, events_network.c needs:

#include <string.h>

to remove the warning. I wish I noticed this before the release, but the
warning didn't jump out at me from the rest of the compilation output.

I'm not sure if this is a header worth including just in case or
something I will just have to patch in my port. Either way it's probably
not worth doing another point release, I can always remove the patch if
you decide to include the header at a later date.

Thanks again for spiped and especially tarsnap!
--
James Turner
***@calminferno.net
Colin Percival
2012-11-16 07:49:19 UTC
Permalink
Post by James Turner
When I submitted the updated port to the OpenBSD mailing list I had the
../lib/events/events_network.c:222: warning: incompatible implicit
declaration of built-in function 'memset'
#include <string.h>
to remove the warning. I wish I noticed this before the release, but the
warning didn't jump out at me from the rest of the compilation output.
This is a bug in OpenBSD -- <sys/select.h> is specified as providing FD_ZERO
and no caveats are mentioned about also needing to include <string.h>:
http://pubs.opengroup.org/onlinepubs/9699919799/
Post by James Turner
I'm not sure if this is a header worth including just in case or
something I will just have to patch in my port. Either way it's probably
not worth doing another point release, I can always remove the patch if
you decide to include the header at a later date.
I'm not going to add an #include which POSIX doesn't require. Whether you
add a patch to spiped in the OpenBSD ports tree or fix OpenBSD or simply
ignore the warning is entirely up to you. :-)
Post by James Turner
Thanks again for spiped and especially tarsnap!
You're welcome! Thanks for helping to make them more widely used.
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Thordur Ivar Bjornsson
2012-11-16 07:57:39 UTC
Permalink
Post by Colin Percival
Post by James Turner
When I submitted the updated port to the OpenBSD mailing list I had the
../lib/events/events_network.c:222: warning: incompatible implicit
declaration of built-in function 'memset'
#include <string.h>
to remove the warning. I wish I noticed this before the release, but the
warning didn't jump out at me from the rest of the compilation output.
This is a bug in OpenBSD -- <sys/select.h> is specified as providing FD_ZERO
http://pubs.opengroup.org/onlinepubs/9699919799/
Post by James Turner
I'm not sure if this is a header worth including just in case or
something I will just have to patch in my port. Either way it's probably
not worth doing another point release, I can always remove the patch if
you decide to include the header at a later date.
Unfortunately the headers in OpenBSD are not very POSIX-y (I keep hitting
this while trying
to steal/port code to Linux :), however there has been/is ongoing work
towards fixing this.

I suggest you contact *Philip Guenther* (***@openbsd.org) has he has
been
very active in fixing up issues like this.
Post by Colin Percival
I'm not going to add an #include which POSIX doesn't require. Whether you
add a patch to spiped in the OpenBSD ports tree or fix OpenBSD or simply
ignore the warning is entirely up to you. :-)
Post by James Turner
Thanks again for spiped and especially tarsnap!
You're welcome! Thanks for helping to make them more widely used.
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
--
ciao, thorduri.
Loading...