Discussion:
spiped 1.2.1 released
Colin Percival
2012-08-31 23:39:57 UTC
Permalink
Hi all,

I've just released spiped 1.2.1; the only non-documentation change is the
addition of an #include <stdint.h> in pushbits.c to fix the build breakage
there.

Note that I haven't added any workaround for the OS X (c99 -lrt fails) or
OpenBSD (<sys/socket.h> doesn't define required types) POSIX violations, so
those platforms will still need patches to build spiped.

If there's any other build breakage, please let me know!
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
James Turner
2012-09-01 00:03:08 UTC
Permalink
Post by Colin Percival
Hi all,
I've just released spiped 1.2.1; the only non-documentation change is the
addition of an #include <stdint.h> in pushbits.c to fix the build breakage
there.
Note that I haven't added any workaround for the OS X (c99 -lrt fails) or
OpenBSD (<sys/socket.h> doesn't define required types) POSIX violations, so
those platforms will still need patches to build spiped.
If there's any other build breakage, please let me know!
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
I've submitted a port [0] to OpenBSD with the appropriate patches, so
hopefully it will get imported.

[0] http://marc.info/?l=openbsd-ports&m=134645718729013&w=2
--
James Turner
***@calminferno.net
Colin Percival
2012-09-01 00:21:27 UTC
Permalink
Post by James Turner
I've submitted a port [0] to OpenBSD with the appropriate patches, so
hopefully it will get imported.
[0] http://marc.info/?l=openbsd-ports&m=134645718729013&w=2
Cool, hopefully this will get more people using spiped.

Two minor suggestions:

1. In the FreeBSD port I'm installing the spiped and spipe README files as
README-foo, while you're installing them as README.foo; I think there's a
(very weak) argument to be made for consistency in the names these are
installed under.

2. I don't know how compatible OpenBSD's rc.d code is with FreeBSD's, but
you might find that the rc.d script I wrote for FreeBSD is useful, either
as-is or as an inspiration for an OpenBSD rc.d script:
http://svnweb.freebsd.org/ports/head/sysutils/spiped/files/spiped.in?revision=300897&view=markup
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
James Turner
2012-09-01 03:13:36 UTC
Permalink
Post by Colin Percival
Post by James Turner
I've submitted a port [0] to OpenBSD with the appropriate patches, so
hopefully it will get imported.
[0] http://marc.info/?l=openbsd-ports&m=134645718729013&w=2
Cool, hopefully this will get more people using spiped.
1. In the FreeBSD port I'm installing the spiped and spipe README files as
README-foo, while you're installing them as README.foo; I think there's a
(very weak) argument to be made for consistency in the names these are
installed under.
2. I don't know how compatible OpenBSD's rc.d code is with FreeBSD's, but
you might find that the rc.d script I wrote for FreeBSD is useful, either
http://svnweb.freebsd.org/ports/head/sysutils/spiped/files/spiped.in?revision=300897&view=markup
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
I've taken your considerations into account and submitted an updated
port [0]. I changed the README naming style to use hyphens rather then dots.

I also included a simple rc script. OpenBSD's pkg rc.d system isn't as
complex as FreeBSD's so the rc script uses the ssh tunnel example for
it's default daemon flags.

[0] http://marc.info/?l=openbsd-ports&m=134646865431077&w=2
--
James Turner
***@calminferno.net
Berk D. Demir
2012-09-01 04:34:18 UTC
Permalink
Post by Colin Percival
Hi all,
I've just released spiped 1.2.1; the only non-documentation change is the
addition of an #include <stdint.h> in pushbits.c to fix the build breakage
there.
Note that I haven't added any workaround for the OS X (c99 -lrt fails) or
OpenBSD (<sys/socket.h> doesn't define required types) POSIX violations, so
those platforms will still need patches to build spiped.
If there's any other build breakage, please let me know!
I updated my homebrew repo with 1.2.1 and about to send a pull request.
After reading the discussion here I realized I wasn't installing
README files to the documentation directory and while on it, I
realized README of spipe has a single char typo where usage line says
'spiped' instead of 'spipe'. I also patch this along with '-lrt'
removal from LDADD. It's a minor error but I will hold sending a pull
request until I get a reply from you. The options I can think of are:
1) fix and release 1.2.2, 2) fix it in 1.2.1 and ask package
maintainers to update the checksums (ugh!) 3) ignore it until the next
release.

Here's my commit.
https://github.com/bdd/homebrew/commit/1f81b60e8c066026cf481c94a949fe9defddd8c3
Colin Percival
2012-09-01 21:46:49 UTC
Permalink
Post by Berk D. Demir
Post by Colin Percival
If there's any other build breakage, please let me know!
I updated my homebrew repo with 1.2.1 and about to send a pull request.
After reading the discussion here I realized I wasn't installing
README files to the documentation directory and while on it, I
realized README of spipe has a single char typo where usage line says
'spiped' instead of 'spipe'.
*sigh*

Obviously I need to get more careful when I copy material from one program
to reuse for another...
Post by Berk D. Demir
I also patch this along with '-lrt'
removal from LDADD. It's a minor error but I will hold sending a pull
1) fix and release 1.2.2, 2) fix it in 1.2.1 and ask package
maintainers to update the checksums (ugh!) 3) ignore it until the next
release.
I've fixed it in my tree (along with removing a couple of unnecessary
object files which were being linked into the spipe code), and I'm inclined
to release a version 1.2.2... but not quite yet. Given that this is a
non-critical issue, I'll wait a week or so in case any more problems get
noticed -- I don't want to end up doing a 1.2.3 as well!
--
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Loading...